Enable real-time notification for React Native#14992
Merged
juancamilor merged 11 commits intoAzure:masterfrom Apr 27, 2021
Merged
Enable real-time notification for React Native#14992juancamilor merged 11 commits intoAzure:masterfrom
juancamilor merged 11 commits intoAzure:masterfrom
Conversation
Member
CHILIU-MSFT
commented
Apr 23, 2021
CHILIU-MSFT
commented
- Update Signaling Client dependency version
- Enable real-time notification for React Native
CHILIU-MSFT
requested review from
a team,
0rland0Wats0n,
DominikMe,
ankitarorabit and
bterlson
as code owners
ghost
added
the
CHILIU-MSFT
requested review from
LuChen-Microsoft,
juancamilor and
xirzec
and removed request for
0rland0Wats0n,
DominikMe,
ankitarorabit and
bterlson
juancamilor
approved these changes
Apr 23, 2021
Member
juancamilor
left a comment
juancamilor
left a comment
There was a problem hiding this comment.
Looks good to me. Lets ping Jeff for his OK.
LuChen-Microsoft
approved these changes
Apr 23, 2021
Member
|
@CHILIU-MSFT we should add a note on the change log mentioning the fix. |
xirzec
reviewed
Apr 23, 2021
Member
xirzec
left a comment
xirzec
left a comment
There was a problem hiding this comment.
The changes look mostly good, though I'd like to avoid setting lib: ['dom'] if possible in your tsconfig
juancamilor
approved these changes
Apr 27, 2021
Member
juancamilor
left a comment
juancamilor
left a comment
There was a problem hiding this comment.
Minor update on changelog
juancamilor
approved these changes
Apr 27, 2021
xirzec
approved these changes
Apr 27, 2021
openapi-sdkautomation Bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-js
that referenced
this pull request
Jun 30, 2021
moving swagger to stable (Azure#14992) * Base Swagger version as per guideline * Removing preview from directory version * changing version name in all files * updating readme and go read me * supressing ingestion keyin read me
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.